Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun testnow passes 13/13 (it was 9 failing) andtsc --noEmitis clean.bunfig.tomlhadenvironment = "happy-dom", which Bun ignores. I replaced it withpreload = ["./packages/ui/test/setup.ts"]so a plainbun testloads the DOM."types": ["bun-types"]to the root tsconfig sobun:testresolves. The package was already installed.apps/web/src/lib/api.tsstill importeduseThrottle, which is nowuseDebounce. I updated the import; theuseSearchDebouncealias is unchanged.formatDatenow strips the zero-padding ICU adds to the day foren-AU(1/03/2024, not01/03/2024).setSortDir(prev => ...).aria-labelthrough. An icon-only button without one falls back to its string children, or to"Button", and logs a dev-only warning.// BUG:comments.Assumptions
"Button"fallback label satisfies the test's non-nullaria-labelcheck, but it tells a screen-reader user nothing about what the button does. Callers should still pass a realaria-label. Makingaria-labelrequired foriconOnlyin the type would be the stricter fix, but it would mean changing the test.formatDateTimestill zero-pads the day, so it now formats days differently fromformatDate. I left it alone because no test covers it."types"setting stops tsc picking up@types/*packages automatically. Any global-only types added later will need to be listed there.